Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (7ddb7be) to head (4fa72dc).

@@           Coverage Diff           @@
##           master    #1956   +/-   ##
=======================================
  Coverage   86.87%   86.87%           
=======================================
  Files          16       16           
  Lines        1410     1410           
=======================================
  Hits         1225     1225           
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This should not be considered a blocker but I would REALLY like to see an example dataset with this type of data added to the BIDS examples repository.

Will ping all the people who reacted on the associated issue to see if anyone is up for this.

@dorahermes @cimbi @EmmanuelBarbeau @michaelpereira73 @KLehongre @tjr1

I just need permission

Note that the example datasets are 'emptied' of any data: https://github.com/bids-standard/bids-examples/blob/master/CONTRIBUTING.md#why-do-we-only-host-truncated-data-with-0kb-size

This should also make it easier to 'share' them, though we prefer when possible to make sure that the full 'source' dataset we are using is also openly accessible, but this is not a requirement.

I meant the 'large' datafiles in the example datasets are truncated:

see here for how we do it.

https://github.com/bids-standard/bids-examples/blob/master/CONTRIBUTING.md#how-to-truncate-data-files-to-0kb

I guess header only files must be pretty light, so I think this could do as well. @effigies what do you think?

BIDS examples are strictly about directory structure, file naming and BIDS-specified metadata. This allows us to validate the examples to exercise the rules.

If we intend to duplicate format-internal metadata in BIDS metadata and validate that they are the same, it's worth including enough header information to check that. We have one example with NIfTI files truncated to the header to do this, but otherwise the NIfTI files are truncated to 0 bytes and the header checks skipped.

This is not to say that there shouldn't be a place with a working MED example, just that that's not what bids-examples is for. What's ideal is if there is a canonical example, we can strip it down with a script for inclusion in bids-examples and link back to the original.

Fork https://github.com/bids-standard/bids-examples/ and add it in a pull request.

@Remi-Gau Are we good to go with bids-standard/bids-examples#469?

@Remi-Gau Are we good to go with bids-standard/bids-examples#469?

yes it should be fine: I have some comments but they are minor and not related to the format so cna be tackled in follow up PR.